Messages in this thread | | | Date | Tue, 22 Nov 2016 16:49:01 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH] drm/sun4i: Fix a return value in case of error |
| |
On Fri, Nov 18, 2016 at 07:18:47PM +0100, Christophe JAILLET wrote: > If 'sun4i_backend_drm_format_to_layer()' does not return 0, then 'val' is > left unmodified. > As it is not initialized either, the return value can be anything. > > It is likely that returning the error code was expected here. > > As the only caller of 'sun4i_backend_update_layer_formats()' does not check > the return value, this fix is purely theorical. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied, thanks! Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |