Messages in this thread | | | Date | Tue, 22 Nov 2016 12:31:50 -0200 | From | Mauro Carvalho Chehab <> | Subject | Re: [Intel-gfx] [PATCH 1/4] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages |
| |
Em Mon, 14 Nov 2016 09:55:48 +0000 Chris Wilson <chris@chris-wilson.co.uk> escreveu:
> On Fri, Nov 11, 2016 at 08:50:17AM +0000, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > > > Scatterlist entries have an unsigned int for the offset so > > correct the sg_alloc_table_from_pages function accordingly. > > > > Since these are offsets withing a page, unsigned int is > > wide enough. > > > > Also converts callers which were using unsigned long locally > > with the lower_32_bits annotation to make it explicitly > > clear what is happening. > > > > v2: Use offset_in_page. (Chris Wilson) > > > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > > Cc: Pawel Osciak <pawel@osciak.com> > > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > > Cc: Kyungmin Park <kyungmin.park@samsung.com> > > Cc: Tomasz Stanislawski <t.stanislaws@samsung.com> > > Cc: Matt Porter <mporter@kernel.crashing.org> > > Cc: Alexandre Bounine <alexandre.bounine@idt.com> > > Cc: linux-media@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Acked-by: Marek Szyprowski <m.szyprowski@samsung.com> (v1) > > If there were kerneldoc, it would nicely explain that having an offset > larger then a page is silly when passing in array of pages. > > Changes elsewhere look ok (personally I'd be happy with just > offset_in_page(), 4GiB superpages are somebody else's problem :)
For the media changes, that looked OK. We don't have any needs to stream 4GB images nowadays :-)
Reviewed-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> > -Chris >
Thanks, Mauro
| |