lkml.org 
[lkml]   [2016]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr not provided
On Mon, 21 Nov 2016, Zubair Lutfullah Kakakhel wrote:
> On 11/18/2016 01:29 PM, Thomas Gleixner wrote:
> I'll elaborate on the commit message.
>
> The DT node in arch/powerpc for this driver is
>
> intc_0: interrupt-controller@81800000 {
> #interrupt-cells = <0x2>;
> compatible = "xlnx,xps-intc-1.00.a";
> interrupt-controller ;
> reg = < 0x81800000 0x10000 >;
> xlnx,num-intr-inputs = <0xc>;
> } ;
>
> The DT node in arch/microblaze for this driver is
>
> intc_0: interrupt-controller@81800000 {
> #interrupt-cells = <0x2>;
> compatible = "xlnx,xps-intc-1.00.a";
> interrupt-controller ;
> reg = < 0x81800000 0x10000 >;
> xlnx,kind-of-intr = <0x100>; //<Missing from ppc>!
> xlnx,num-intr-inputs = <0x9>;
> } ;
>
> The PPC driver assumes the kind-of-intr value be 0x0 and doesn't specify it in
> DT.
> This patch makes that a fall back case. Instead of completely error-ing out.

Ok. makes sense. I misread the changelog/patch.

Thanks,

tglx

\
 
 \ /
  Last update: 2016-11-21 16:51    [W:0.062 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site