Messages in this thread | | | From | Axel Haslam <> | Date | Mon, 21 Nov 2016 11:27:49 +0100 | Subject | Re: [PATCH v3 10/10] ARM: dts: da850: add usb device node |
| |
On Mon, Nov 21, 2016 at 3:42 AM, David Lechner <david@lechnology.com> wrote: > On 11/07/2016 02:39 PM, Axel Haslam wrote: >> >> This adds the ohci device node for the da850 soc. >> It also enables it for the omapl138 hawk board. >> >> Signed-off-by: Axel Haslam <ahaslam@baylibre.com> >> --- >> arch/arm/boot/dts/da850-lcdk.dts | 8 ++++++++ >> arch/arm/boot/dts/da850.dtsi | 8 ++++++++ >> 2 files changed, 16 insertions(+) >> >> diff --git a/arch/arm/boot/dts/da850-lcdk.dts >> b/arch/arm/boot/dts/da850-lcdk.dts >> index 7b8ab21..aaf533e 100644 >> --- a/arch/arm/boot/dts/da850-lcdk.dts >> +++ b/arch/arm/boot/dts/da850-lcdk.dts >> @@ -86,6 +86,14 @@ >> }; >> }; >> >> +&usb_phy { >> + status = "okay"; >> +}; >> + >> +&ohci { >> + status = "okay"; >> +}; >> + >> &serial2 { >> pinctrl-names = "default"; >> pinctrl-0 = <&serial2_rxtx_pins>; >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >> index 2534aab..50e86da 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -405,6 +405,14 @@ >> >; >> status = "disabled"; >> }; >> + ohci: usb@0225000 { > > > In commit 2957e36e76c836b167e5e0c1edb578d8a9bd7af6 in the linux-davinci > tree, the alias for the musb device is usb0. So, I think we should use usb1 > here instead of ohci - or change the usb0 alias to musb. > > https://git.kernel.org/cgit/linux/kernel/git/nsekhar/linux-davinci.git/commit/?h=v4.10/dt&id=2957e36e76c836b167e5e0c1edb578d8a9bd7af6
ok, i will change to usb1, since i will be resubmiting this.
> >> + compatible = "ti,da830-ohci"; >> + reg = <0x225000 0x1000>; >> + interrupts = <59>; >> + phys = <&usb_phy 1>; >> + phy-names = "usb-phy"; >> + status = "disabled"; >> + }; >> gpio: gpio@226000 { >> compatible = "ti,dm6441-gpio"; >> gpio-controller; >> >
| |