lkml.org 
[lkml]   [2016]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4] staging: slicoss: fix different address space warnings
    On Sat, Nov 19, 2016 at 2:20 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
    > On Fri, Nov 18, 2016 at 06:57:18PM +0100, Sergio Paracuellos wrote:
    >> Remove incorrect __iomem annotation.
    >>
    >> This patch fix the following sparse warnings in slicoss driver:
    >> warning: incorrect type in assignment (different address spaces)
    >>
    >> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
    >> ---
    >> drivers/staging/slicoss/slic.h | 2 +-
    >> 1 file changed, 1 insertion(+), 1 deletion(-)
    >>
    >> diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
    >> index 420546d..14d7555 100644
    >> --- a/drivers/staging/slicoss/slic.h
    >> +++ b/drivers/staging/slicoss/slic.h
    >> @@ -380,7 +380,7 @@ struct slic_shmemory {
    >> dma_addr_t isr_phaddr;
    >> dma_addr_t lnkstatus_phaddr;
    >> dma_addr_t stats_phaddr;
    >> - struct slic_shmem_data __iomem *shmem_data;
    >> + struct slic_shmem_data *shmem_data;
    >
    > But, is this the correct fix? It looks like shmem_data is being treated
    > like a pointer to io memory, so we need to use the correct accessors for
    > that memory, and not just a "raw" pointer, right? Removing this marking
    > seems to be moving backwards...

    That was the intention of v3 of the patch. But after Dan suggestions I
    though that just
    removing this mark would be enough because it was wrong. I am a little
    lost now :)

    Cheers,
    Sergio Paracuellos

    >
    > thanks,
    >
    > greg k-h

    \
     
     \ /
      Last update: 2016-11-20 09:22    [W:3.429 / U:0.664 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site