Messages in this thread | | | Subject | Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower | From | Larry Finger <> | Date | Wed, 2 Nov 2016 20:00:03 -0500 |
| |
On 10/30/2016 05:21 AM, John Heenan wrote: > Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set > macpower, is never 0xea. It is only ever 0x01 (first time after modprobe) > using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results > occurs with 'Fix for authentication failure' [PATCH 1/2] in place. > > Whatever was returned, code tests always showed that at least > rtl8xxxu_init_queue_reserved_page(priv); > is always required. Not called if macpower set to true. > > Please see cover letter, [PATCH 0/2], for more information from tests.
That cover letter will NOT be included in the commit message, thus referring to it here is totally pointless.
> > For rtl8xxxu-devel branch of git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git
Same comment as for the previous patch.
Again I leave the review of the code changes to Jes.
Larry
| |