Messages in this thread | | | Subject | Re: [PATCH (net.git) 2/3] stmmac: fix PTP support for GMAC4 | From | Giuseppe CAVALLARO <> | Date | Wed, 2 Nov 2016 07:34:01 +0100 |
| |
Hello Rayagond
if patches are ok, can we consider you Acked-by ?
Thx Peppe
On 10/27/2016 12:51 PM, Rayagond Kokatanur wrote: > On Thu, Oct 27, 2016 at 4:02 PM, Giuseppe CAVALLARO > <peppe.cavallaro@st.com> wrote: >> Hello Rayagond ! >> >> On 10/27/2016 12:25 PM, Rayagond Kokatanur wrote: >>>> >>>> +static int dwmac4_wrback_get_rx_timestamp_status(void *desc, u32 ats) >>>>> { >>>>> struct dma_desc *p = (struct dma_desc *)desc; >>>>> + int ret = -EINVAL; >>>>> + >>>>> + /* Get the status from normal w/b descriptor */ >>>>> + if (likely(p->des3 & TDES3_RS1V)) { >>>>> + if (likely(p->des1 & RDES1_TIMESTAMP_AVAILABLE)) { >>>>> + int i = 0; >>>>> + >>>>> + /* Check if timestamp is OK from context >>>>> descriptor */ >>>>> + do { >>>>> + ret = dwmac4_rx_check_timestamp(desc); >>> >>> Here, "desc" is not pointing to next descriptor (ie context >>> descriptor). Driver should check the context descriptor. >> >> >> you are right and this is done by the caller: stmmac_get_rx_hwtstamp > > Yes. > >> >> Cheers >> peppe >> > > >
| |