lkml.org 
[lkml]   [2016]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC v8 05/28] clocksource: h8300_timer8: don't reset rate in ->set_state_oneshot()
    Date
    With the upcoming NTP correction related rate adjustments to be implemented
    in the clockevents core, the latter needs to get informed about every rate
    change of a clockevent device made after its registration.

    Currently, h8300_timer8 violates this requirement in that it registers its
    clockevent device with the correct rate, but resets its ->mult and ->rate
    values in timer8_clock_event_start(), called from its ->set_state_oneshot()
    function.

    It seems like
    commit 4633f4cac85a ("clocksource/drivers/h8300: Cleanup startup and
    remove module code."),
    which introduced the rate initialization at registration, missed to remove
    the manual setting of ->mult and ->shift from timer8_clock_event_start().

    Purge the setting of ->mult, ->shift, ->min_delta_ns and ->max_delta_ns
    from timer8_clock_event_start().

    Signed-off-by: Nicolai Stange <nicstange@gmail.com>
    ---

    Notes:
    Compile-only tested on ARCH=h8300.

    drivers/clocksource/h8300_timer8.c | 8 --------
    1 file changed, 8 deletions(-)

    diff --git a/drivers/clocksource/h8300_timer8.c b/drivers/clocksource/h8300_timer8.c
    index 546bb18..804c489 100644
    --- a/drivers/clocksource/h8300_timer8.c
    +++ b/drivers/clocksource/h8300_timer8.c
    @@ -101,15 +101,7 @@ static inline struct timer8_priv *ced_to_priv(struct clock_event_device *ced)

    static void timer8_clock_event_start(struct timer8_priv *p, unsigned long delta)
    {
    - struct clock_event_device *ced = &p->ced;
    -
    timer8_start(p);
    -
    - ced->shift = 32;
    - ced->mult = div_sc(p->rate, NSEC_PER_SEC, ced->shift);
    - ced->max_delta_ns = clockevent_delta2ns(0xffff, ced);
    - ced->min_delta_ns = clockevent_delta2ns(0x0001, ced);
    -
    timer8_set_next(p, delta);
    }

    --
    2.10.2
    \
     
     \ /
      Last update: 2016-11-19 17:02    [W:4.445 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site