Messages in this thread | | | Subject | Re: [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic | From | David Hildenbrand <> | Date | Fri, 18 Nov 2016 20:25:30 +0100 |
| |
Am 18.11.2016 um 20:20 schrieb Paolo Bonzini: > > > On 18/11/2016 19:20, David Hildenbrand wrote: >> Am 17.11.2016 um 15:55 schrieb Paolo Bonzini: >>> kvm_arch_set_irq is unused since commit b97e6de9c96. Merge >>> its functionality with kvm_arch_set_irq_inatomic. >>> >>> Reported-by: Jiang Biao <jiang.biao2@zte.com.cn> >>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> >>> --- >> >> As you said, it is unused. Therefore the functionality is superfluous. >> Why merge it? > > Because we can handle Hyper-V synthetic interrupts atomically, and that > was the intended usage of kvm_arch_set_irq's code (see commit > c9a5eccac1ab, "kvm/eventfd: add arch-specific set_irq", 2015-10-16). > > What happened was that the API changed between commit c9a5eccac1ab and > the merge of the Hyper-V synthetic interrupt patches, and the latter was > not adjusted. >
Alright, got it. Thanks for the explanation. So
Reviewed-by: David Hildenbrand <david@redhat.com>
--
David
| |