lkml.org 
[lkml]   [2016]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] kvm: x86: merge kvm_arch_set_irq and kvm_arch_set_irq_inatomic
From
Date
Am 18.11.2016 um 20:20 schrieb Paolo Bonzini:
>
>
> On 18/11/2016 19:20, David Hildenbrand wrote:
>> Am 17.11.2016 um 15:55 schrieb Paolo Bonzini:
>>> kvm_arch_set_irq is unused since commit b97e6de9c96. Merge
>>> its functionality with kvm_arch_set_irq_inatomic.
>>>
>>> Reported-by: Jiang Biao <jiang.biao2@zte.com.cn>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>
>> As you said, it is unused. Therefore the functionality is superfluous.
>> Why merge it?
>
> Because we can handle Hyper-V synthetic interrupts atomically, and that
> was the intended usage of kvm_arch_set_irq's code (see commit
> c9a5eccac1ab, "kvm/eventfd: add arch-specific set_irq", 2015-10-16).
>
> What happened was that the API changed between commit c9a5eccac1ab and
> the merge of the Hyper-V synthetic interrupt patches, and the latter was
> not adjusted.
>

Alright, got it. Thanks for the explanation. So

Reviewed-by: David Hildenbrand <david@redhat.com>

--

David

\
 
 \ /
  Last update: 2016-11-18 20:26    [W:0.049 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site