lkml.org 
[lkml]   [2016]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] x86/mce: Include the PPIN in machine check records when it is available
Date
Borislav Petkov <bp@suse.de> writes:
>
>> @@ -2134,8 +2140,37 @@ static int __init mcheck_enable(char *str)
>> }
>> __setup("mce", mcheck_enable);
>>
>> +static void mcheck_intel_ppin_init(void)
>
> So this functionality could all be moved to arch/x86/kernel/cpu/intel.c
> where you could set an artificial X86_FEATURE_PPIN and get rid of the
> have_ppin var.


That means that a tiny kernel that compiles out machine check
functionality has this unnecessary code.

In general it doesn't make any sense to define a FEATURE flag for
a single user. It's better to just check it where it is needed.

-Andi

\
 
 \ /
  Last update: 2016-11-18 18:04    [W:0.101 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site