Messages in this thread | | | Subject | Re: [PATCH v8 12/16] drivers: iommu: arm-smmu: split probe functions into DT/generic portions | From | Robin Murphy <> | Date | Fri, 18 Nov 2016 16:43:30 +0000 |
| |
On 18/11/16 16:00, Will Deacon wrote: > On Wed, Nov 16, 2016 at 03:29:32PM +0000, Lorenzo Pieralisi wrote: >> Current ARM SMMU probe functions intermingle HW and DT probing >> in the initialization functions to detect and programme the ARM SMMU >> driver features. In order to allow probing the ARM SMMU with other >> firmwares than DT, this patch splits the ARM SMMU init functions into >> DT and HW specific portions so that other FW interfaces (ie ACPI) can >> reuse the HW probing functions and skip the DT portion accordingly. >> >> This patch implements no functional change, only code reshuffling. >> >> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >> Reviewed-by: Tomasz Nowicki <tn@semihalf.com> >> Tested-by: Hanjun Guo <hanjun.guo@linaro.org> >> Tested-by: Tomasz Nowicki <tn@semihalf.com> >> Cc: Will Deacon <will.deacon@arm.com> >> Cc: Hanjun Guo <hanjun.guo@linaro.org> >> Cc: Robin Murphy <robin.murphy@arm.com> >> --- >> drivers/iommu/arm-smmu.c | 62 +++++++++++++++++++++++++++++------------------- >> 1 file changed, 37 insertions(+), 25 deletions(-) > > Reviewed-by: Will Deacon <will.deacon@arm.com> > > Although I'd also like Robin to have a look at this.
Sorry, I've been slow this week. Having finally got round to taking a proper look, I swear this seems even tidier than the last version I looked at closely. It doesn't break DT boot on my Juno, either.
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> > Will >
| |