lkml.org 
[lkml]   [2016]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.8 60/92] perf top: Fix refreshing hierarchy entries on TUI
    Date
    4.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Namhyung Kim <namhyung@kernel.org>

    commit c611152373e84a7677cd7d496e849de4debdab66 upstream.

    Markus reported that 'perf top --hierarchy' cannot scroll down after
    refresh. This was because the number of entries are not updated when
    hierarchy is enabled.

    Unlike normal report view, hierarchy mode needs to keep its own entry
    count since it can have non-leaf entries which can expand/collapse.

    Reported-and-Tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Andi Kleen <andi@firstfloor.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Fixes: f5b763feebe9 ("perf hists browser: Count number of hierarchy entries")
    Link: http://lkml.kernel.org/r/20161007050412.3000-1-namhyung@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    tools/perf/ui/browsers/hists.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/tools/perf/ui/browsers/hists.c
    +++ b/tools/perf/ui/browsers/hists.c
    @@ -595,7 +595,8 @@ int hist_browser__run(struct hist_browse
    u64 nr_entries;
    hbt->timer(hbt->arg);

    - if (hist_browser__has_filter(browser))
    + if (hist_browser__has_filter(browser) ||
    + symbol_conf.report_hierarchy)
    hist_browser__update_nr_entries(browser);

    nr_entries = hist_browser__nr_entries(browser);

    \
     
     \ /
      Last update: 2016-11-17 11:59    [W:4.786 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site