lkml.org 
[lkml]   [2016]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 02/38] ALSA: info: Limit the proc text input size
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 027a9fe6835620422b6713892175716f3613dd9d upstream.

    The ALSA proc handler allows currently the write in the unlimited size
    until kmalloc() fails. But basically the write is supposed to be only
    for small inputs, mostly for one line inputs, and we don't have to
    handle too large sizes at all. Since the kmalloc error results in the
    kernel warning, it's better to limit the size beforehand.

    This patch adds the limit of 16kB, which must be large enough for the
    currently existing code.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/core/info.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/sound/core/info.c
    +++ b/sound/core/info.c
    @@ -331,6 +331,9 @@ static ssize_t snd_info_text_entry_write
    if (!valid_pos(pos, count))
    return -EIO;
    next = pos + count;
    + /* don't handle too large text inputs */
    + if (next > 16 * 1024)
    + return -EIO;
    mutex_lock(&entry->access);
    buf = data->wbuffer;
    if (!buf) {

    \
     
     \ /
      Last update: 2016-11-17 11:39    [W:2.224 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site