Messages in this thread | | | From | "Huang\, Ying" <> | Subject | Re: GHES platform devices | Date | Thu, 17 Nov 2016 09:27:02 +0800 |
| |
Hi, Bjorn,
Bjorn Helgaas <helgaas@kernel.org> writes:
> Hi Huang, > > 7ad6e9435596 ("ACPI, APEI, Manage GHES as platform devices") added > platform devices so the GHES driver could be built as a module and > automatically loaded when needed. > > Later, 86cd47334b00 ("ACPI, APEI, GHES, Prevent GHES to be built as > module") removed the ability to build GHES as a module. > > Should we revert 7ad6e9435596? It's inconsistent to handle GHES, but > not other error sources, as a platform device. And having it as a > platform device probably puts gunk in sysfs that we don't need.
Although other error sources are not platform devices, I think it is generally good to make GHES platform devices. To take advantage of automatic module loading, we can make ghes a module again, but prevent it from unloading. What do you think about that?
Best Regards, Huang, Ying
| |