Messages in this thread | | | Date | Wed, 16 Nov 2016 14:23:47 -0800 | From | Stephen Boyd <> | Subject | Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write |
| |
On 11/16, Vivek Gautam wrote: > Hi Stephen, > > On Wed, Nov 16, 2016 at 12:29 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > > On 11/15, Vivek Gautam wrote: > >> @@ -53,7 +53,7 @@ static int qfprom_remove(struct platform_device *pdev) > >> static struct nvmem_config econfig = { > >> .name = "qfprom", > >> .owner = THIS_MODULE, > >> - .stride = 4, > >> + .stride = 1, > > > > Are we certain that all qfproms support byte accesses? > > I have tested on 8916 and 8996. Will give a try on older targets as > well. > > For a note: we had been using the reg_stride = 1, before removing > regmap support for nvmem access [1]. > > [1] 382c62f nvmem: qfprom: remove nvmem regmap dependency > >
Ah ok. If we were doing byte accesses before then I have no concerns.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |