Messages in this thread | | | Date | Wed, 16 Nov 2016 12:16:44 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] regulator: max77620: add support to configure MPOK |
| |
On Wed, Nov 16, 2016 at 05:22:40PM +0530, Venkat Reddy Talla wrote:
> Adding support to configure regulator POK mapping bit > to control nRST_IO and GPIO1 POK function.
This leaves me none the wiser as to what this is supposed to do...
> + if (chip->chip_id == MAX20024) {
Please use switch statements so we can add new cases without rewriting everything.
> + ret = of_property_read_u32(np, "maxim,power-ok-control", &pval); > + rpdata->power_ok = (!ret) ? pval : -1; > +
Please write normal logic statements, people need to be able to read the code and understand what it does. [unhandled content-type:application/pgp-signature] | |