lkml.org 
[lkml]   [2016]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] ovl: use kernel facility for copying attributes
On Tue, Nov 15, 2016 at 5:54 PM, Quorum Laval <quorum.laval@gmail.com> wrote:
> Replace ovl_copyattr() by fsstack_copy_attr_all() and drop the definition of
> the former.

This isn't trivially correct, fsstack_copy_attr_all() copies more than
ovl_copyattr(). We need a better explanation for why it is correct
to copy all the other attributes as well.

Thanks,
Miklos

\
 
 \ /
  Last update: 2016-11-16 10:24    [W:0.044 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site