Messages in this thread | | | Subject | Re: [PATCH V4 7/8] thermal: da9062/61: Thermal junction temperature monitoring driver | From | Lukasz Luba <> | Date | Tue, 15 Nov 2016 09:46:51 +0000 |
| |
On 14/11/16 08:22, Steve Twiss wrote: > From: Steve Twiss <stwiss.opensource@diasemi.com> > > Add junction temperature monitoring supervisor device driver, compatible > with the DA9062 and DA9061 PMICs. A MODULE_DEVICE_TABLE() macro is added. > > If the PMIC's internal junction temperature rises above TEMP_WARN (125 > degC) an interrupt is issued. This TEMP_WARN level is defined as the > THERMAL_TRIP_HOT trip-wire inside the device driver. > > The thermal triggering mechanism is interrupt based and happens when the > temperature rises above a given threshold level. The component cannot > return an exact temperature, it only has knowledge if the temperature is > above or below a given threshold value. A status bit must be polled to > detect when the temperature falls below that threshold level again. A > kernel work queue is configured to repeatedly poll and detect when the > temperature falls below this trip-wire, between 1 and 10 second intervals > (defaulting at 3 seconds). > > This first level of temperature supervision is intended for non-invasive > temperature control, where the necessary measures for cooling the system > down are left to the host software. > > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com> > Looks good to me.
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Regards, Lukasz
| |