Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 15 Nov 2016 10:19:21 +0100 | Subject | Re: [PATCH v3 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN,UP} argument |
| |
On Fri, Nov 11, 2016 at 10:50 AM, Chen-Yu Tsai <wens@csie.org> wrote:
> According to pinconf-generic.h, the argument for > PIN_CONFIG_BIAS_PULL_{DOWN,UP} is non-zero if the bias is enabled > with a pull up/down resistor, zero if it is directly connected > to VDD or ground. > > Since Allwinner hardware uses a weak pull resistor internally, > the argument should be 1. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Applied this v3 rather than the v2.
Yours, Linus Walleij
| |