lkml.org 
[lkml]   [2016]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/3] remoteproc: qcom: add Venus video core firmware loader driver
    On 11/07, Stanimir Varbanov wrote:
    > +#include <linux/module.h>
    > +#include <linux/of_reserved_mem.h>
    > +#include <linux/platform_device.h>
    > +#include <linux/qcom_scm.h>
    > +#include <linux/remoteproc.h>
    > +
    > +#include "qcom_mdt_loader.h"
    > +#include "remoteproc_internal.h"
    > +
    > +#define VENUS_CRASH_REASON_SMEM 425

    This is unused. Is there going to be some common smem API to get
    the crash reason?
    > +
    > +static const struct of_device_id venus_of_match[] = {
    > + { .compatible = "qcom,venus-pil" },
    > + { },
    > +};

    Add a MODULE_DEVICE_TABLE?

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    a Linux Foundation Collaborative Project

    \
     
     \ /
      Last update: 2016-11-14 20:17    [W:4.117 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site