Messages in this thread Patch in this message | | | Subject | Re: [patch] HID: wacom: Don't clear bits unintentionally | From | Jason Gerecke <> | Date | Mon, 14 Nov 2016 10:31:52 -0800 |
| |
On 11/10/2016 11:25 AM, Dan Carpenter wrote: > This is trying to clear the lower 32 bits but the type is wrong so it > clears everything. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >
Reviewed-by: Jason Gerecke <jason.gerecke@wacom.com>
Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours....
> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c > index 0723ba8..1cf4608 100644 > --- a/drivers/hid/wacom_wac.c > +++ b/drivers/hid/wacom_wac.c > @@ -1765,7 +1765,7 @@ static int wacom_wac_pen_event(struct hid_device *hdev, struct hid_field *field, > wacom_wac->hid_data.tipswitch |= value; > return 0; > case HID_DG_TOOLSERIALNUMBER: > - wacom_wac->serial[0] = (wacom_wac->serial[0] & ~0xFFFFFFFF); > + wacom_wac->serial[0] = (wacom_wac->serial[0] & ~0xFFFFFFFFULL); > wacom_wac->serial[0] |= value; > return 0; > case WACOM_HID_WD_SENSE: > --
| |