Messages in this thread | | | Subject | Re: [PATCH v2 0/2] bnx2: Wait for in-flight DMA to complete at probe stage | From | Paul Menzel <> | Date | Mon, 14 Nov 2016 18:35:17 +0100 |
| |
On 11/14/16 18:28, David Miller wrote: > From: Paul Menzel <pmenzel@molgen.mpg.de> > Date: Mon, 14 Nov 2016 09:25:47 +0100
>> On 11/13/16 06:01, Baoquan He wrote: >>> This is v2 post. >>> >>> In commit 3e1be7a ("bnx2: Reset device during driver initialization"), >>> firmware requesting code was moved from open stage to probe stage. >>> The reason is in kdump kernel hardware iommu need device be reset in >>> driver probe stage, otherwise those in-flight DMA from 1st kernel >>> will continue going and look up into the newly created io-page tables. >>> However bnx2 chip resetting involves firmware requesting issue, that >>> need be done in open stage. >>> >>> Michale Chan suggested we can just wait for the old in-flight DMA to >>> complete at probe stage, then though without device resetting, we >>> don't need to worry the old in-flight DMA could continue looking up >>> the newly created io-page tables. >>> >>> v1->v2: >>> Michael suggested to wait for the in-flight DMA to complete at probe >>> stage. So give up the old method of trying to reset chip at probe >>> stage, take the new way accordingly. >> >> thank you for posting the updated series. Could you please resend a v3 >> with stable@vger.kernel.org added [1]? > > This is not the proper procedure for networking patches.
Oh, I didn’t know that. Sorry for spreading false information.
Kind regards,
Paul
| |