Messages in this thread | | | Date | Mon, 14 Nov 2016 16:14:48 +0100 | From | Oleg Nesterov <> | Subject | Re: sched/autogroup: race if !sysctl_sched_autogroup_enabled ? |
| |
On 11/13, Mike Galbraith wrote: > > Autogroup never should have had knobs in the first place, and now, Oleg has > discovered that the dynamic enable/disable capability either has become, or > perhaps always was racy.
It was always racy afaics, even if sysctl_sched_autogroup_enabled doesn't change. So this patch is not enough.
But the main reason I dislike it is that I can't backport it ;) rhel7 runs with sysctl_sched_autogroup_enabled=0 by default, and users actually use this knob to enable it dynamically.
Mike, et al, sorry for delay. I'll try to finally force myself to write the comments and the changelog and send 2 (trivial) fixes today.
Oleg.
| |