lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 085/346] crypto: nx - off by one bug in nx_of_update_msc()
    3.16.39-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit e514cc0a492a3f39ef71b31590a7ef67537ee04b upstream.

    The props->ap[] array is defined like this:

    struct alg_props ap[NX_MAX_FC][NX_MAX_MODE][3];

    So we can see that if msc->fc and msc->mode are == to NX_MAX_FC or
    NX_MAX_MODE then we're off by one.

    Fixes: ae0222b7289d ('powerpc/crypto: nx driver code supporting nx encryption')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/crypto/nx/nx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/crypto/nx/nx.c
    +++ b/drivers/crypto/nx/nx.c
    @@ -330,7 +330,7 @@ static void nx_of_update_msc(struct devi
    ((bytes_so_far + sizeof(struct msc_triplet)) <= lenp) &&
    i < msc->triplets;
    i++) {
    - if (msc->fc > NX_MAX_FC || msc->mode > NX_MAX_MODE) {
    + if (msc->fc >= NX_MAX_FC || msc->mode >= NX_MAX_MODE) {
    dev_err(dev, "unknown function code/mode "
    "combo: %d/%d (ignored)\n", msc->fc,
    msc->mode);
    \
     
     \ /
      Last update: 2016-11-14 04:59    [W:4.028 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site