lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 104/152] ARM: sa1111: fix pcmcia suspend/resume
    3.2.84-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Russell King <rmk+kernel@armlinux.org.uk>

    commit 06dfe5cc0cc684e735cb0232fdb756d30780b05d upstream.

    SA1111 PCMCIA was broken when PCMCIA switched to using dev_pm_ops for
    the PCMCIA socket class. PCMCIA used to handle suspend/resume via the
    socket hosting device, which happened at normal device suspend/resume
    time.

    However, the referenced commit changed this: much of the resume now
    happens much earlier, in the noirq resume handler of dev_pm_ops.

    However, on SA1111, the PCMCIA device is not accessible as the SA1111
    has not been resumed at _noirq time. It's slightly worse than that,
    because the SA1111 has already been put to sleep at _noirq time, so
    suspend doesn't work properly.

    Fix this by converting the core SA1111 code to use dev_pm_ops as well,
    and performing its own suspend/resume at noirq time.

    This fixes these errors in the kernel log:

    pcmcia_socket pcmcia_socket0: time out after reset
    pcmcia_socket pcmcia_socket1: time out after reset

    and the resulting lack of PCMCIA cards after a S2RAM cycle.

    Fixes: d7646f7632549 ("pcmcia: use dev_pm_ops for class pcmcia_socket_class")
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    arch/arm/common/sa1111.c | 22 +++++++++++++---------
    1 file changed, 13 insertions(+), 9 deletions(-)

    --- a/arch/arm/common/sa1111.c
    +++ b/arch/arm/common/sa1111.c
    @@ -878,9 +878,9 @@ struct sa1111_save_data {

    #ifdef CONFIG_PM

    -static int sa1111_suspend(struct platform_device *dev, pm_message_t state)
    +static int sa1111_suspend_noirq(struct device *dev)
    {
    - struct sa1111 *sachip = platform_get_drvdata(dev);
    + struct sa1111 *sachip = dev_get_drvdata(dev);
    struct sa1111_save_data *save;
    unsigned long flags;
    unsigned int val;
    @@ -938,9 +938,9 @@ static int sa1111_suspend(struct platfor
    * restored by their respective drivers, and must be called
    * via LDM after this function.
    */
    -static int sa1111_resume(struct platform_device *dev)
    +static int sa1111_resume_noirq(struct device *dev)
    {
    - struct sa1111 *sachip = platform_get_drvdata(dev);
    + struct sa1111 *sachip = dev_get_drvdata(dev);
    struct sa1111_save_data *save;
    unsigned long flags, id;
    void __iomem *base;
    @@ -956,7 +956,7 @@ static int sa1111_resume(struct platform
    id = sa1111_readl(sachip->base + SA1111_SKID);
    if ((id & SKID_ID_MASK) != SKID_SA1111_ID) {
    __sa1111_remove(sachip);
    - platform_set_drvdata(dev, NULL);
    + dev_set_drvdata(dev, NULL);
    kfree(save);
    return 0;
    }
    @@ -1002,8 +1002,8 @@ static int sa1111_resume(struct platform
    }

    #else
    -#define sa1111_suspend NULL
    -#define sa1111_resume NULL
    +#define sa1111_suspend_noirq NULL
    +#define sa1111_resume_noirq NULL
    #endif

    static int __devinit sa1111_probe(struct platform_device *pdev)
    @@ -1037,6 +1037,11 @@ static int sa1111_remove(struct platform
    return 0;
    }

    +static struct dev_pm_ops sa1111_pm_ops = {
    + .suspend_noirq = sa1111_suspend_noirq,
    + .resume_noirq = sa1111_resume_noirq,
    +};
    +
    /*
    * Not sure if this should be on the system bus or not yet.
    * We really want some way to register a system device at
    @@ -1049,10 +1054,9 @@ static int sa1111_remove(struct platform
    static struct platform_driver sa1111_device_driver = {
    .probe = sa1111_probe,
    .remove = sa1111_remove,
    - .suspend = sa1111_suspend,
    - .resume = sa1111_resume,
    .driver = {
    .name = "sa1111",
    + .pm = &sa1111_pm_ops,
    },
    };

    \
     
     \ /
      Last update: 2016-11-14 03:13    [W:2.243 / U:1.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site