lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration
On Fri, Nov 11, 2016 at 09:31:09PM +0100, Arnd Bergmann wrote:
> On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote:
> > > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc)
> > > void dwc3_host_exit(struct dwc3 *dwc)
> > > {
> > > phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy",
> > > - dev_name(&dwc->xhci->dev));
> > > + dev_name(dwc->dev));
> > > phy_remove_lookup(dwc->usb3_generic_phy, "usb3-phy",
> > > - dev_name(&dwc->xhci->dev));
> > > + dev_name(dwc->dev));
> >
> > this looks unrelated to $subject. Care to explain?
>
> bus->sysdev is used for retrieving any information that comes from
> the platform (DT or otherwise), and the phy lookup in has to be done
> through sysdev as well because the platform cannot add it to
> the child device it has no knowledge of.
>
> When we set the sysdev to the parent, the phy lookup has to be
> added to that device as well, rather than the child device.
>

Then, the device should change to dwc->sysdev, and phy_create_lookup
in this file needs to change too.

--

Best Regards,
Peter Chen

\
 
 \ /
  Last update: 2016-11-14 02:52    [W:1.733 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site