lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] usb: mtu3: declare functions static
From
Date
Hi,

On Sun, 2016-11-13 at 20:45 +0000, Sudip Mukherjee wrote:
> The only user of the functions mtu3_irq() and gpd_ring_empty() are in
> the same file. They can be declared as static.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
> drivers/usb/mtu3/mtu3_core.c | 2 +-
> drivers/usb/mtu3/mtu3_qmu.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c
> index 520e55a..603b7f84 100644
> --- a/drivers/usb/mtu3/mtu3_core.c
> +++ b/drivers/usb/mtu3/mtu3_core.c
> @@ -696,7 +696,7 @@ static irqreturn_t mtu3_u2_common_isr(struct mtu3 *mtu)
> return IRQ_HANDLED;
> }
>
> -irqreturn_t mtu3_irq(int irq, void *data)
> +static irqreturn_t mtu3_irq(int irq, void *data)
> {
> struct mtu3 *mtu = (struct mtu3 *)data;
> unsigned long flags;
> diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c
> index a6dd292..7d9ba8a 100644
> --- a/drivers/usb/mtu3/mtu3_qmu.c
> +++ b/drivers/usb/mtu3/mtu3_qmu.c
> @@ -168,7 +168,7 @@ static struct qmu_gpd *advance_deq_gpd(struct mtu3_gpd_ring *ring)
> }
>
> /* check if a ring is emtpy */
> -int gpd_ring_empty(struct mtu3_gpd_ring *ring)
> +static int gpd_ring_empty(struct mtu3_gpd_ring *ring)
> {
> struct qmu_gpd *enq = ring->enqueue;
> struct qmu_gpd *next;
It's my carelessness.

Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Thanks

\
 
 \ /
  Last update: 2016-11-14 02:37    [W:0.335 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site