lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task
    On Fri, Nov 11, 2016 at 11:16:59PM +0100, Rafael J. Wysocki wrote:
    > > + struct sched_param param = { .sched_priority = 50 };
    >
    > I'd define a symbol for the 50. It's just one extra line of code ...

    A minor point for sure, but in general what's the motivation for
    defining symbols for things which are only used once? It makes it harder
    to untangle and learn a piece of code IMO, having to jump to the
    definitions of them to see what they are.

    thanks,
    Steve

    \
     
     \ /
      Last update: 2016-11-13 20:50    [W:3.444 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site