lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 21/26] staging: iio: tsl2583: clarified comment about clearing interrupts
From
Date
On 12/11/16 18:19, Brian Masney wrote:
> The comment that describes the code that clears the interrupt bit was
> vague and didn't provide much value. This patch adds more detail about
> why that bit needs to be cleared.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
Applied.
> ---
> drivers/staging/iio/light/tsl2583.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index 806cb0a..727ed49 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -205,8 +205,9 @@ static int tsl2583_get_lux(struct iio_dev *indio_dev)
> }
>
> /*
> - * clear status, really interrupt status (interrupts are off), but
> - * we use the bit anyway - don't forget 0x80 - this is a command
> + * Clear the pending interrupt status bit on the chip to allow the next
> + * integration cycle to start. This has to be done even though this
> + * driver currently does not support interrupts.
> */
> ret = i2c_smbus_write_byte(chip->client,
> (TSL2583_CMD_REG | TSL2583_CMD_SPL_FN |
>

\
 
 \ /
  Last update: 2016-11-13 13:29    [W:0.377 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site