lkml.org 
[lkml]   [2016]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.8 21/35] ipv4: disable BH in set_ping_group_range()
    Date
    4.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Dumazet <edumazet@google.com>


    [ Upstream commit a681574c99be23e4d20b769bf0e543239c364af5 ]

    In commit 4ee3bd4a8c746 ("ipv4: disable BH when changing ip local port
    range") Cong added BH protection in set_local_port_range() but missed
    that same fix was needed in set_ping_group_range()

    Fixes: b8f1a55639e6 ("udp: Add function to make source port for UDP tunnels")
    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Reported-by: Eric Salo <salo@google.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv4/sysctl_net_ipv4.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/net/ipv4/sysctl_net_ipv4.c
    +++ b/net/ipv4/sysctl_net_ipv4.c
    @@ -109,10 +109,10 @@ static void set_ping_group_range(struct
    kgid_t *data = table->data;
    struct net *net =
    container_of(table->data, struct net, ipv4.ping_group_range.range);
    - write_seqlock(&net->ipv4.ip_local_ports.lock);
    + write_seqlock_bh(&net->ipv4.ip_local_ports.lock);
    data[0] = low;
    data[1] = high;
    - write_sequnlock(&net->ipv4.ip_local_ports.lock);
    + write_sequnlock_bh(&net->ipv4.ip_local_ports.lock);
    }

    /* Validate changes from /proc interface. */

    \
     
     \ /
      Last update: 2016-11-13 12:35    [W:2.091 / U:0.984 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site