Messages in this thread | | | Date | Sat, 12 Nov 2016 19:01:17 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH v3 2/3] Coccinelle: misc: Improve the result given by context mode |
| |
On Mon, 24 Oct 2016, Vaishali Thakkar wrote:
> To eliminate false positives given by the context mode, add > necessary arguments for the function request_threaded_irq. > > Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> --- > Changes since v2: > - Add missing declaration of metavariable irq > Changes since v1: > - Split patch in to the patch set > --- > scripts/coccinelle/misc/irqf_oneshot.cocci | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci > index a8537fb..e53372e 100644 > --- a/scripts/coccinelle/misc/irqf_oneshot.cocci > +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci > @@ -87,9 +87,10 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, > ) > > @depends on context@ > +expression irq; > position p != {r1.p,r2.p}; > @@ > -*request_threaded_irq@p(...) > +*request_threaded_irq@p(irq, NULL, ...) > > @match depends on report || org@ > expression irq; > -- > 2.1.4 > >
| |