Messages in this thread | | | Date | Fri, 11 Nov 2016 14:54:52 -0800 | From | Stephen Boyd <> | Subject | Re: [PATCH v3 3/9] media: venus: adding core part and helper functions |
| |
On 11/11, Stanimir Varbanov wrote: > On 11/10/2016 11:43 PM, Stephen Boyd wrote: > > > > Should this be ret |= ? Only the last time through the loop will > > there be an error. Or perhaps we should be bailing out early from > > this loop? > > I think that even if unset_buffers fail we need to free the memory. In > case of an error in firmware while unset buffers we should mark the > session as invalid and abort the session acordingly.
Ok. So perhaps we shouldn't have any return value for this function then?
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |