lkml.org 
[lkml]   [2016]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] x86/cpufeatures: Enable new AVX512 cpu features
Date
Hi Boris,

-----Original Message-----
From: Borislav Petkov [mailto:bp@alien8.de]
Sent: Wednesday, November 9, 2016 1:19 AM
To: Kammela, Gayatri <gayatri.kammela@intel.com>
Cc: mingo@elte.hu; linux-kernel@vger.kernel.org; x86@kernel.org; H . Peter Anvin <hpa@linux.intel.com>; Shankar, Ravi V <ravi.v.shankar@intel.com>; Yu, Fenghua <fenghua.yu@intel.com>
Subject: Re: [PATCH] x86/cpufeatures: Enable new AVX512 cpu features

On Tue, Nov 08, 2016 at 04:08:44PM -0800, Gayatri Kammela wrote:
> Modify cpufeatures.h to add new AVX512 instruction groups/features for
> enuermation in /proc/cpuinfo: AVX512IFMA and AVX512VBMI
>
> Also modify the xstate.c to clear the flags in
> fpu__xstate_clear_all_cpu_caps().

>>This is already visible in the diff itself, no need to explain what the patch does.
Sure , I will make changes

>>Also, please run your commit message through a spellchecker.
My bad , thanks for letting me know!
> CPUID.(EAX=7,ECX=0):EBX[bit 21] AVX512IFMA CPUID.(Eax=7,ECX=0):ECX[bit
> 1] AVX512VBMI

>>s/Eax/EAX/
Sure

> Detailed information of cpuid bits for the features can be found in
> Intel Architecture Instruction Set Extensions Programming Reference.

>>We have recently started uploading such documents into bugzilla.kernel.org in order to have a stable reference source, see

>>https://lkml.kernel.org/r/alpine.DEB.2.20.1611082002160.3501@nanos

>>Please do so too and add the link to the commit message.

Since this is not bug or bug fix ,I am not sure under which product section in https://bugzilla.kernel.org/ should I upload the document for these two new features.
>>Rest looks ok to me.

>>Thanks.

>>--
>>Regards/Gruss,
>> Boris.

>>Good mailing practices for 400: avoid top-posting and trim the reply.
\
 
 \ /
  Last update: 2016-11-11 21:09    [W:0.057 / U:46.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site