lkml.org 
[lkml]   [2016]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/2] mmc: allow mmc_alloc_host() and tmio_mmc_host_alloc()
    On Thu, Nov 10, 2016 at 10:24:21PM +0900, Masahiro Yamada wrote:
    >
    > sdhci_alloc_host() returns an error pointer when it fails.
    > but mmc_alloc_host() cannot.
    >
    > This series allow to propagate a proper error code
    > when host-allocation fails.

    Why? What can we really do about the error except give up? Why does
    having a explicit error value make any difference to the caller, they
    can't do anything different, right?

    I suggest just leaving it as-is, it's simple, and you don't have to mess
    with PTR_ERR() anywhere.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2016-11-10 14:36    [W:3.459 / U:0.824 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site