Messages in this thread | | | Subject | Re: [PATCH] drivers: cpuidle: assign enter_freeze to same as enter callback function | From | Sudeep Holla <> | Date | Thu, 10 Nov 2016 10:34:31 +0000 |
| |
On 10/11/16 10:28, Vincent Guittot wrote: > On 9 November 2016 at 19:48, Sudeep Holla <sudeep.holla@arm.com> wrote: >> >> >> On 09/11/16 18:39, Lorenzo Pieralisi wrote:
[..]
>>> I would just init the enter_freeze() pointer and be done with that, >>> adding code to check whether the idle back-end enables IRQs when it >>> enters idle is a major PITA that really is not worth the hassle and >>> apart from coupled C-states (which we do not support in DT as you said) >>> I can't find another example (and on top of that it is not even >>> something we can solve through DT since it is not a property of the idle >>> state but more related to its kernel implementation). >>> >> >> Makes sense, I was just trying to avoid setting for a state like >> CPU/Cluster retention but I agree, we need not do that. > > I agree with Lorenzo and would prefer to keep it simple >
Sure I will respin accordingly.
-- Regards, Sudeep
| |