Messages in this thread | | | From | Vivien Didelot <> | Subject | Re: [PATCH net-next 08/11] net: dsa: mv88e6xxx: add port duplex setter | Date | Wed, 02 Nov 2016 02:12:03 +0100 |
| |
Hi Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
>> int (*port_set_link)(struct mv88e6xxx_chip *chip, int port, int link); >> + >> + /* Port's MAC duplex mode >> + * >> + * Use DUPLEX_HALF or DUPLEX_FULL to force half or full duplex, or >> + * DUPLEX_UNKNOWN for normal duplex detection. >> + */ >> + int (*port_set_duplex)(struct mv88e6xxx_chip *chip, int port, int dup); > > Again, i think DUPLEX_UNFORCED, or DUPLEX_AUTO would be better.
DUPLEX_UNKNOWN and SPEED_UNKNOWN are existing values used by the phy/ethtool interface for the phy_device. I prefered to use them when possible instead of creating new ones.
Thanks,
Vivien
| |