lkml.org 
[lkml]   [2016]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] UBIFS: Remove some dead code
From
Date


On 01.11.2016 07:45, Christophe JAILLET wrote:
> 'ubifs_fast_find_freeable()' can not return an error pointer, so this test
> can be removed.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> fs/ubifs/gc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c
> index e845c64b6ce1..7b35e3d6cde7 100644
> --- a/fs/ubifs/gc.c
> +++ b/fs/ubifs/gc.c
> @@ -846,10 +846,6 @@ int ubifs_gc_start_commit(struct ubifs_info *c)
> */
> while (1) {
> lp = ubifs_fast_find_freeable(c);
> - if (IS_ERR(lp)) {
> - err = PTR_ERR(lp);
> - goto out;
> - }

Good catch, how did you find this?
If you have a tool/script I'd like to use it too.

Thanks,
//richard

\
 
 \ /
  Last update: 2016-11-01 12:43    [W:0.903 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site