Messages in this thread | | | Date | Fri, 7 Oct 2016 15:43:14 +0200 | From | Pavel Machek <> | Subject | Re: [patch 12/32] greybus: es2 host driver |
| |
On Fri 2016-09-16 15:25:25, Greg KH wrote: > This is a Greybus host driver for the ES2/3 bridge chip from Toshiba. > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > ---
> +/* > + * @endpoint: bulk in endpoint for CPort data > + * @urb: array of urbs for the CPort in messages > + * @buffer: array of buffers for the @cport_in_urb urbs > + */ > +struct es2_cport_in { > + __u8 endpoint; > + struct urb *urb[NUM_CPORT_IN_URB]; > + u8 *buffer[NUM_CPORT_IN_URB];
Underscored versions of __u8 and friends are unneccessary here... as shown later in the struct. Makes sense to fix in whole file. pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |