lkml.org 
[lkml]   [2016]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.7 077/141] pstore: drop file opened reference count
    Date
    4.7-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Geliang Tang <geliangtang@163.com>

    commit 52d210d961a62a9662e27f14d6505d6741b2fb02 upstream.

    In ee1d267423a1 ("pstore: add pstore unregister") I added:
    .owner = THIS_MODULE,
    in both pstore_fs_type and pstore_file_operations to increase a reference
    count when pstore filesystem is mounted and pstore file is opened.

    But, it's repetitive. There is no need to increase the opened reference
    count. We only need to increase the mounted reference count. When a file
    is opened, the filesystem can't be unmounted. Hence the pstore module
    can't be unloaded either.

    So I drop the opened reference count in this patch.

    Fixes: ee1d267423a1 ("pstore: add pstore unregister")
    Signed-off-by: Geliang Tang <geliangtang@163.com>
    Signed-off-by: Kees Cook <keescook@chromium.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/pstore/inode.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/fs/pstore/inode.c
    +++ b/fs/pstore/inode.c
    @@ -178,7 +178,6 @@ static loff_t pstore_file_llseek(struct
    }

    static const struct file_operations pstore_file_operations = {
    - .owner = THIS_MODULE,
    .open = pstore_file_open,
    .read = pstore_file_read,
    .llseek = pstore_file_llseek,

    \
     
     \ /
      Last update: 2016-10-06 11:48    [W:4.227 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site