Messages in this thread | | | From | Richard Weinberger <> | Date | Thu, 6 Oct 2016 11:29:20 +0200 | Subject | Re: [PATCH 24/54] md/raid1: Improve another size determination in setup_conf() |
| |
On Thu, Oct 6, 2016 at 11:22 AM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 4 Oct 2016 21:46:18 +0200 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer.
Isn't this pure matter of taste? Some developers prefer sizeof(*ptr) because it is easier to type, other developers prefer sizeof(struct foo) because you can determine the type at first sight and makes review more easy.
-- Thanks, //richard
| |