lkml.org 
[lkml]   [2016]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 71/93] ASoC: omap-mcpdm: Fix irq resource handling
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Peter Ujfalusi <peter.ujfalusi@ti.com>

    commit a8719670687c46ed2e904c0d05fa4cd7e4950cd1 upstream.

    Fixes: ddd17531ad908 ("ASoC: omap-mcpdm: Clean up with devm_* function")

    Managed irq request will not doing any good in ASoC probe level as it is
    not going to free up the irq when the driver is unbound from the sound
    card.

    Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
    Reported-by: Russell King <linux@armlinux.org.uk>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/soc/omap/omap-mcpdm.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/sound/soc/omap/omap-mcpdm.c
    +++ b/sound/soc/omap/omap-mcpdm.c
    @@ -390,8 +390,8 @@ static int omap_mcpdm_probe(struct snd_s
    pm_runtime_get_sync(mcpdm->dev);
    omap_mcpdm_write(mcpdm, MCPDM_REG_CTRL, 0x00);

    - ret = devm_request_irq(mcpdm->dev, mcpdm->irq, omap_mcpdm_irq_handler,
    - 0, "McPDM", (void *)mcpdm);
    + ret = request_irq(mcpdm->irq, omap_mcpdm_irq_handler, 0, "McPDM",
    + (void *)mcpdm);

    pm_runtime_put_sync(mcpdm->dev);

    @@ -416,6 +416,7 @@ static int omap_mcpdm_remove(struct snd_
    {
    struct omap_mcpdm *mcpdm = snd_soc_dai_get_drvdata(dai);

    + free_irq(mcpdm->irq, (void *)mcpdm);
    pm_runtime_disable(mcpdm->dev);

    return 0;

    \
     
     \ /
      Last update: 2016-10-06 11:07    [W:5.042 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site