lkml.org 
[lkml]   [2016]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 9/9] s390: virtio: make ccw explicitly non-modular
    On Sun, 30 Oct 2016 16:37:32 -0400
    Paul Gortmaker <paul.gortmaker@windriver.com> wrote:

    > The Kconfig currently controlling compilation of this code is:
    >
    > arch/s390/Kconfig:config S390_GUEST
    > arch/s390/Kconfig: def_bool y
    >
    > ...meaning that it currently is not being built as a module by anyone.
    >
    > Lets remove the modular code that is essentially orphaned, so that
    > when reading the driver there is no doubt it is builtin-only.
    >
    > Since module_init translates to device_initcall in the non-modular
    > case, the init ordering remains unchanged with this commit.
    >
    > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
    >
    > We replace module.h with moduleparam.h since the file does declare
    > some module_param() and leaving that as-is is currently the easiest
    > way to remain compatible with existing boot arg use cases.
    >
    > Cc: Christian Borntraeger <borntraeger@de.ibm.com>
    > Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
    > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
    > Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
    > Cc: linux-s390@vger.kernel.org
    > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    > ---
    > drivers/s390/virtio/virtio_ccw.c | 25 ++-----------------------
    > 1 file changed, 2 insertions(+), 23 deletions(-)

    There might actually be a case for making this modular, as the
    virtio-pci transport can be built as a module as well. But I don't
    think anybody really cares, and your patch is easily reverted should we
    want to do this later, so

    Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>

    [going through the s390 tree with the other patches is probably easier
    as taking this through the virtio tree]

    \
     
     \ /
      Last update: 2016-10-31 11:56    [W:3.661 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site