lkml.org 
[lkml]   [2016]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] nvdimm: use the right length of "pmem"
From
Date
On 30/10/16 16:50, Dan Williams wrote:
> On Sat, Oct 29, 2016 at 4:28 AM, Nicolas Iooss
> <nicolas.iooss_linux@m4x.org> wrote:
>> In order to test that the name of a resource begins with "pmem", call
>> strncmp() with 4 as length instead of 3 to match the whole prefix.
>>
>> Fixes: 16660eaea0cc ("libnvdimm, namespace: update label implementation
>> for multi-pmem")
>> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
>
> Thanks, although I would not call this out as a fix since the length
> parameter could be 1 and still do the right thing. I.e. we're
> distinguishing "blk" from "pmem" resources. I'll add this for 4.10 as
> a cleanup.

All right. Thanks for your quick reply!

Nicolas

\
 
 \ /
  Last update: 2016-10-30 17:58    [W:0.045 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site