lkml.org 
[lkml]   [2016]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 3/4] virtio_blk: Delete an unnecessary initialisation in init_vq()
    On Tue, Sep 13, 2016 at 1:14 PM, SF Markus Elfring
    <elfring@users.sourceforge.net> wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Tue, 13 Sep 2016 13:43:50 +0200
    >
    > The local variable "err" will be set to an appropriate value
    > by a following statement.
    > Thus omit the explicit initialisation at the beginning.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/block/virtio_blk.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
    > index d28dbcf..696f452 100644
    > --- a/drivers/block/virtio_blk.c
    > +++ b/drivers/block/virtio_blk.c
    > @@ -376,7 +376,7 @@ static void virtblk_config_changed(struct virtio_device *vdev)
    >
    > static int init_vq(struct virtio_blk *vblk)
    > {
    > - int err = 0;
    > + int err;
    > int i;
    > vq_callback_t **callbacks;
    > const char **names;

    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

    \
     
     \ /
      Last update: 2016-10-03 11:10    [W:4.076 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site