lkml.org 
[lkml]   [2016]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.8 006/125] drm/amdgpu/dce10: disable hpd on local panels
    Date
    4.8-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alex Deucher <alexander.deucher@amd.com>

    commit e96ec90f496603c48e0945f8bdeb4cdf3088cbba upstream.

    Otherwise we can get a hotplug interrupt storm when
    we turn the panel off if hpd interrupts were enabled
    by the bios.

    bug:
    https://bugs.freedesktop.org/show_bug.cgi?id=97471

    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 23 +++++++++++++----------
    1 file changed, 13 insertions(+), 10 deletions(-)

    --- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
    +++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
    @@ -425,16 +425,6 @@ static void dce_v10_0_hpd_init(struct am
    list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
    struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);

    - if (connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
    - connector->connector_type == DRM_MODE_CONNECTOR_LVDS) {
    - /* don't try to enable hpd on eDP or LVDS avoid breaking the
    - * aux dp channel on imac and help (but not completely fix)
    - * https://bugzilla.redhat.com/show_bug.cgi?id=726143
    - * also avoid interrupt storms during dpms.
    - */
    - continue;
    - }
    -
    switch (amdgpu_connector->hpd.hpd) {
    case AMDGPU_HPD_1:
    idx = 0;
    @@ -458,6 +448,19 @@ static void dce_v10_0_hpd_init(struct am
    continue;
    }

    + if (connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
    + connector->connector_type == DRM_MODE_CONNECTOR_LVDS) {
    + /* don't try to enable hpd on eDP or LVDS avoid breaking the
    + * aux dp channel on imac and help (but not completely fix)
    + * https://bugzilla.redhat.com/show_bug.cgi?id=726143
    + * also avoid interrupt storms during dpms.
    + */
    + tmp = RREG32(mmDC_HPD_INT_CONTROL + hpd_offsets[idx]);
    + tmp = REG_SET_FIELD(tmp, DC_HPD_INT_CONTROL, DC_HPD_INT_EN, 0);
    + WREG32(mmDC_HPD_INT_CONTROL + hpd_offsets[idx], tmp);
    + continue;
    + }
    +
    tmp = RREG32(mmDC_HPD_CONTROL + hpd_offsets[idx]);
    tmp = REG_SET_FIELD(tmp, DC_HPD_CONTROL, DC_HPD_EN, 1);
    WREG32(mmDC_HPD_CONTROL + hpd_offsets[idx], tmp);

    \
     
     \ /
      Last update: 2016-10-29 16:16    [W:4.190 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site