Messages in this thread | | | Date | Fri, 28 Oct 2016 13:08:22 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH 1/4] printk/NMI: Handle continuous lines and missing newline |
| |
On (10/27/16 09:35), Joe Perches wrote: [..] > > - printk_nmi_flush_line(buf, (end - start) + 1); > > + /* Handle continuous lines or missing new line. */ > > + if ((c + 1 < end) && printk_get_level(c)) { > > + if (header) { > > + c += 2; > > printk_skip_level
agree, printk_skip_level() probably would look better here. other than that, looks good to me. nice that you found it, Petr!
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
| |