Messages in this thread | | | Subject | Re: [PATCH 2/3] ASoC: lpass-platform: Fix broken pcm data usage | From | Srinivas Kandagatla <> | Date | Fri, 28 Oct 2016 22:11:35 +0100 |
| |
On 28/10/16 19:26, Mark Brown wrote: > On Fri, Oct 28, 2016 at 04:32:19PM +0100, Srinivas Kandagatla wrote: >> This patch fixes lpass-platform driver which was broken in v4.9-rc1. >> lpass_pcm_data data structure holds information specific to stream. >> Holding a single private pointer to it in global lpass_data >> will not work, because it would be overwritten by for each pcm instance. > > This is a bug fix but you've made it depend on patch 1 which is just a > refactoring and should therefore not be sent to Linus as a fix. Please > don't do this, fix bugs first then do any cleanups and new > functionality. That way we can send fixes to Linus without needing to > pull in extra stuff. Sorry about that, I will resend the fix patch without any dependencies.
Thanks, srini
>
| |