lkml.org 
[lkml]   [2016]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote:

[...]

> >>> Could you share the log? Is there any log about failure?
> >>
> >> Sure, please see below log:
> >
> > It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller.
> > Maybe hi6220 has handled the reset controller(?)...
> >
> > I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER..
>
> Could you check the below thing..
>
> /* find reset controller when exist */
> - pdata->rstc = devm_reset_control_get_optional(dev, NULL);
> + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
> if (IS_ERR(pdata->rstc)) {
> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
> return ERR_PTR(-EPROBE_DEFER);

Confirmed with this fixing, the kernel can bootup successfully.

Thanks for this.

> To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller?
>
>
> Best Regards,
> Jaehoon Chung

\
 
 \ /
  Last update: 2016-10-28 12:19    [W:0.074 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site