lkml.org 
[lkml]   [2016]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()
From
Date
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 28 Oct 2016 09:29:59 +0200

A return value was not checked from a call of the function "printf".

This issue was detected also by using the Coccinelle software.


Add a bit of exception handling there.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
scripts/basic/fixdep.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
index f5ff6eea..911347a 100644
--- a/scripts/basic/fixdep.c
+++ b/scripts/basic/fixdep.c
@@ -132,7 +132,12 @@ static void usage(void)
*/
static void print_cmdline(void)
{
- printf("cmd_%s := %s\n\n", target, cmdline);
+ if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) {
+ int code = errno;
+
+ perror("fixdep: print_cmdline");
+ exit(code);
+ }
}

/*
--
2.10.1
\
 
 \ /
  Last update: 2016-10-28 10:40    [W:0.260 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site