lkml.org 
[lkml]   [2016]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 8/8] IB/mlx5: Add helper mlx5_ib_post_send_wait
    On Tue, Oct 25, 2016 at 06:46:58PM +0530, Binoy Jayan wrote:
    > On 25 October 2016 at 17:56, Leon Romanovsky <leon@kernel.org> wrote:
    > > On Tue, Oct 25, 2016 at 05:31:59PM +0530, Binoy Jayan wrote:
    >
    > > In case of success (err == 0), you will call to unmap_dma instead of
    > > normal flow.
    > >
    > > NAK,
    > > Leon Romanovsky <leonro@mellanox.com>
    >
    > Hi Loen,
    >
    > Even in the original code, the regular flow seems to reach 'unmap_dma' after
    > returning from 'wait_for_completion'().

    In original flow, the code executed assignments to mr->mmkey. In you
    code, it is skipped.

    http://lxr.free-electrons.com/source/drivers/infiniband/hw/mlx5/mr.c#L900

    >
    > -Binoy
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2016-10-27 08:06    [W:4.208 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site